| 6d3d6bda |
obexd: Show owner vCard in phonebook pb pull
Previously 'owner' vCard was visible in vCard listing of 'pb' but not in
result of pull 'pb' phonebook. Due to that, vCard listing and pull
operations were returning different number of results (also return
values of PhonebookSize request were inconsistent) |
Radoslaw Jablonski |
13 years ago |
1 file, +0, -2 |
| 9b415c73 |
obexd: Fix proper data escaping for vCard listing
Up until now it was possible to inject some XML or just broke returned
vCard listing by preparing contact with some special characters. |
Bartosz Szatkowski |
13 years ago |
1 file, +4, -1 |
| dc162b70 |
obexd: Add SetFolder function for MAP tracker backend |
Bartosz Szatkowski |
13 years ago |
1 file, +232, -4 |
| 36d168bf |
obexd: Add tracker backend stump for MAP |
Bartosz Szatkowski |
13 years ago |
1 file, +98, -0 |
| 934d1c4d |
obexd: Fix no phone number in vCard listing |
Bartosz Szatkowski |
13 years ago |
1 file, +1, -1 |
| d1cacca1 |
obexd: Add opening ebooks before each operation
Until now ebooks were opened only on phonebook_init, but particular ebook
may be offline or not authenticated or user may be offline at the time.
Better idea is try to open ebooks before each operation, especially
as time overhead is minimal. |
Bartosz Szatkowski |
13 years ago |
1 file, +31, -35 |
| 4044473e |
obexd: Fix ebook opening error handling
Individual address book may be not accessible (offline, not
authenticated etc.) it should not prevent plugin to load properly. |
Bartosz Szatkowski |
13 years ago |
1 file, +8, -13 |
| 9204fc1f |
obexd: Fix sent vCard format for eds backend
For now phonebook eds backend supports only vCard 3.0. |
Bartosz Szatkowski |
13 years ago |
1 file, +2, -2 |
| 88a72d54 |
obexd: Fix freeing buffer before transfer is complete
phonebook_req_finalize is called before actual transport taking place,
so buffers kept in user_data may cause invalid reads in valgrind and
prevent transport being completed. |
Bartosz Szatkowski |
13 years ago |
1 file, +8, -2 |
| f83af12e |
obexd: Remove unnecessary return in add_slash func |
Radoslaw Jablonski |
13 years ago |
1 file, +0, -1 |
| eeae1a6f |
obexd: Fix pulling vCard for multiple ebooks
Problem occurred when there were multiple ebooks and the last one was
empty. Reported vCard number was 0 and no data was transported. |
Bartosz Szatkowski |
13 years ago |
1 file, +8, -7 |
| 9e87d21b |
obexd: Add X-IRMC-CALL-DATETIME to single vCard pull
Previously when pulling single vCard there was no difference between
pulling contact or call, now there are separate queries and additional
previously missing data are being sent. |
Bartosz Szatkowski |
13 years ago |
1 file, +9, -1 |
| 5f944a2c |
obexd: Revert handling CALL-DATETIME in PullvCardEntry
This reverts commit 02d8dea9490b8852b837e143a09891817a4965f9.
The constraints for pulling single vCard are to loose and causes other
numbers to be merged into same vCard. Also there is more elegant way of
applying the new changes. |
Bartosz Szatkowski |
13 years ago |
1 file, +7, -23 |
| 4b697665 |
obexd: Remove *hi from mime driver read()
This removes possibility of setting header type in mime driver read()
function as the functionality of adding different header types is now
supported by get_next_header(). |
Slawomir Bochenski |
13 years ago |
8 files, +20, -53 |
| 821da85b |
obexd: Add handling of system D-Bus method calls
Sending system D-Bus method calls (DefaultAdapter, FindAdapter
and RequestSession) and handling of pending D-Bus calls is added
to obex-client. |
Dmitriy Paliy |
13 years ago |
2 files, +198, -1 |
| d89ad62c |
obexd: Split up session_create in separate functions
Connection of RFCOMM and SDP are extracted from session_create function
into session_connect. Such allows making asynchronous calls before
creating connections. |
Dmitriy Paliy |
13 years ago |
1 file, +24, -17 |
| bbcc0f34 |
obexd: Add system bus connection in obex-client
Connection to system bus is added in obex-client. Purpose is to carry
out OBEX transfers within a single adapter's session. |
Dmitriy Paliy |
13 years ago |
2 files, +10, -0 |
| b988fe35 |
obexd: Add get_next_header() function
This adds the function for mime drivers that allows adding OBEX headers
before body streaming is started. |
Slawomir Bochenski |
13 years ago |
3 files, +59, -4 |
| e7856e19 |
obexd: Start OpenOBEX stream automatically
This removes stream argument from service driver get() function. Now the
streaming is started automatically when first portion of data is
received.
Additionally the possibility to not send body header at all is added. This
can be achieved by returning -ENOSTR from mime plugin read() function. |
Slawomir Bochenski |
13 years ago |
11 files, +29, -41 |
| 6a711a17 |
obexd: Escape all text fields in vCard
This adds previously missing escaping of some text attributes in vCards. |
Slawomir Bochenski |
13 years ago |
1 file, +48, -34 |
| 8a68d3c4 |
obexd: Add proper finishing/canceling requests |
Bartosz Szatkowski |
13 years ago |
1 file, +8, -0 |
| 0aee0052 |
obexd: Modify pbap plugin to utilize get_next_header() |
Slawomir Bochenski |
13 years ago |
1 file, +62, -35 |
| 5dfa357b |
obexd: Do not send empty vCard attributes
PBAP specification v1.1, chap. 5.1.4.1 and 5.4.4.1 states that
non-mandatory attributes shall be sent only when their value is not NULL.
In case of vCards this can be simply understood as non-empty, therefore
the patch makes phonebook_add_contact add only mandatory attributes for
specified vCard version as well as those for which values are of non-zero
length. |
Slawomir Bochenski |
13 years ago |
1 file, +9, -22 |
| b17209a9 |
obexd: Add adapter ReleaseSession to obex-client
Release of adapter session is added to obex-client when closing OBEX
transfer. |
Dmitriy Paliy |
13 years ago |
1 file, +10, -0 |
| 37b24b6a |
obexd: Add 0.vcf (me contact) when generating cache
When pulling all contacts self is already present, but it have to
be manually added when generating cache. |
Bartosz Szatkowski |
13 years ago |
1 file, +40, -0 |
| 5c43d671 |
obexd: Add checking ebook availability before processing
Some ebooks may be offline due to lack of internet connection or it may
require prior authorizations. |
Bartosz Szatkowski |
13 years ago |
1 file, +17, -11 |
| 02c765d0 |
obexd: Add constraint on pulled path
EDS backend supports only phonebook (/telecom/pb.vcf). |
Bartosz Szatkowski |
13 years ago |
1 file, +7, -0 |
| 4723f4e6 |
obexd: Change EDS backend to support multiple ebooks
Until now only default ebook was used, this patch change this behaviour
so each function is run on all available (active) ebooks and merging
results from each of them. |
Bartosz Szatkowski |
13 years ago |
1 file, +196, -97 |
| e75e8277 |
obexd: Fix finalize request in callback function
Request shall be finalized in cache_ready_notify callback function.
Otherwise, reference to the request is kept until vobject is closed.
It is correct in current implementation since there are no nested
backend requests when pulling vcard listing.
However, this contradicts to current design (see phonebook_size_result,
query_result, cache_entry_done) and may cause problems if such
implementation would be needed. |
Dmitriy Paliy |
13 years ago |
1 file, +3, -0 |
| 41f82c5d |
obexd: Use correct variable for setting response |
Slawomir Bochenski |
13 years ago |
1 file, +1, -1 |
| 16ca8eb2 |
obexd: Fix invalid memory read when pulling phone book
Data contacts are freed ones in finalize function which is called in
query_result callback function. Calling free_data_contacts(data) twice
for last phone book part causes invalid memory read when dereferencing
data->contacts. |
Dmitriy Paliy |
13 years ago |
1 file, +2, -1 |
| e37a8840 |
obexd: Return empty list for vcardlisting on empty phonebook
This change is needed to be consistent with scenario about pulling empty
phonebook. Previously NOT_FOUND error was returned for vcardlisting when
there were no entries in selected phonebook.
PBAP spec says, that error NOT_FOUND should be returned when phonebook
object could not be found - very strict clients may think that phonebook
does not exist (and in scenario described above phonebook exists but its
content is empty). |
Rafal Michalski |
13 years ago |
1 file, +1, -9 |
| f4950846 |
obexd: Return empty body instead -ENOENT when phonebook is empty
Previously, when doing pull of empty phonebook, NOT FOUND error was
returned. Now returning empty body - this change is needed to pass PTS
testcase TC_PSE_PDF_BV_05_I (this testcase is optional).
PBAP spec says, that error NOT_FOUND should be returned when phonebook
object could not be found - very strict clients may think that phonebook
does not exist (and in scenario described above phonebook exists but its
content is empty). |
Rafal Michalski |
13 years ago |
1 file, +1, -1 |
| 53415d7d |
obexd: Fix white space related coding style issues for gwobex
- Corrected the space between the arguments
- Corrected no space after 'sizeof' |
Syam Sidhardhan |
13 years ago |
2 files, +5, -5 |
| 3724703d |
obexd: Fix white space related coding style issues
- Corrected space before '{'
- Corrected space after 'for'
- Corrected space during array initialization
- Corrected space between function arguments. |
Syam Sidhardhan |
13 years ago |
6 files, +17, -17 |
| d8d19199 |
obexd: remove unnecessary brackets |
Dmitriy Paliy |
13 years ago |
1 file, +1, -2 |
| a0f30548 |
obexd: Fix sending X-IRMC-CALL-DATETIME in PullvCardEntry
Previously when pulling single vCard there was no difference between
pulling contact or call, now there are separate queries and additional
previously missing data are being sent. |
Bartosz Szatkowski |
13 years ago |
1 file, +23, -7 |
| b1004186 |
obexd: Fix crash introduced by f5279bfcedd669bc5d4e88cc1c59807c92226dfb
The callback function actually needs the bluetooth_service structure not
obex_service_driver. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +13, -12 |
| 541f8c4f |
obexd: Add support for Action command to pcsuite plugin
PCSuite service relies on ftp driver |
Luiz Augusto von Dentz |
13 years ago |
3 files, +13, -2 |
| feeb8b39 |
obexd: Add basic support for action commands on ftp driver
This add basic support for copy and move actions for ftp service driver |
Luiz Augusto von Dentz |
13 years ago |
1 file, +99, -0 |
| c5733f53 |
obexd: Add initial support for OBEX Action command |
Luiz Augusto von Dentz |
13 years ago |
5 files, +154, -0 |
| 24475605 |
obexd: Make proper use of user_data when using bt_io_listen
This changes the user_data from server pointer to service driver pointer
since the former is not really used in the callback but the latter is. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -8 |
| 5e76fcd9 |
obexd: Fix build when pcsuite plugin is enabled
Commit 4ae4f7c4949c6e53cd4c874c9cc533038cd03fb2 breakes the pcsuite
plugin by changing the .read API. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -5 |
| a58f4695 |
obexd: Remove redundant code
This removes outdated (no longer used) code from obex_write_stream:
1) Support for sending data injected directly to obj->buf. This was used
for implementing folder listing in commit:
c42eff92a9c2c177f788dd1ec429250e64f69a78.
2) os->finished flag originally used for supporting asynchronous code in
PBAP, introduced in commit:
1a5025349df3dc6134db62afdcd048c00f876b27 |
Slawomir Bochenski |
13 years ago |
2 files, +3, -18 |
| 391e8c2d |
obexd: Revert API changes to mime driver read function
This reverts parts of commit e0b3283e20ba885018010a6a8ae49b7c313958e8.
API changes introduced before were meant to guarantee required PBAP
functionality of sending application parameters header in first packet
of multi-packet response.
However OBEX_FL_FIT_ONE_PACKET does not serve this purpose - it is for
making sure that all headers will fit fully into one packet (thus
FIT_ONE_PACKET), returning error from OBEX_ObjectAddHeader() when this
is not the case.
Starting the body header streaming adds body header immediately to the
outgoing queue, waiting for more data. Any attempts to
OBEX_ObjectAddHeader() different than those with hi == OBEX_HDR_DATA and
OBEX_FL_STREAM_DATA present in flags, will add new header after
currently streamed body and it will be processed after ending streaming
with OBEX_FL_STREAM_DATAEND. Also in this case data is memcpy'd, so no
reason for any additional write_offset counting. |
Slawomir Bochenski |
13 years ago |
8 files, +15, -55 |
| 2fb5146b |
obexd: Send new missed calls count once
Change introduced by commit b0619290e4128bb583268bfbfbb66de9a30ecf7c
prevented calling count query multiple times when getting the phone book
in parts. However value of newmissedcalls was kept between calls to
phonebook_pull_read() resulting in adding application parameters header
multiple times. |
Slawomir Bochenski |
13 years ago |
1 file, +2, -0 |
| be4faac0 |
obexd: Optimise call history queries
This changes order of graph pattern elements, moving OPTIONAL block to
the end of the query. This gives a dramatic performance improvement. |
Slawomir Bochenski |
13 years ago |
1 file, +1, -1 |
| 8a2c7262 |
obexd: Remove unnecessary jumps |
Slawomir Bochenski |
13 years ago |
3 files, +7, -10 |
| d8446e67 |
obexd: Add MAP session management and SetFolder function |
Slawomir Bochenski |
13 years ago |
2 files, +77, -8 |
| 0ec1f880 |
obexd: Add messages backend initialization and finalization
This adds functions for initializing and freeing resources used by
message storage access backend and example implementation in the dummy
(or rather - filesystem) backend.
Dummy backend uses $MAP_ROOT (if set) and falls back to
$HOME/map-messages for its message storage. This directory should at
least contain basic folders required by the MAP specification. It
represents the root as seen from the perspective of MAP client. You can
prepare it as follows:
$ mkdir -p "$MAP_ROOT/telecom/msg/inbox"
$ mkdir "$MAP_ROOT/telecom/msg/sent"
$ mkdir "$MAP_ROOT/telecom/msg/deleted"
$ mkdir "$MAP_ROOT/telecom/msg/outbox" |
Slawomir Bochenski |
13 years ago |
2 files, +29, -0 |