| 60b2e582 |
obexd: Remove obc_transfer_abort
Refactor the code to remove function obc_transfer_abort, which is used
only once and is anyway coupled to the D-Bus API. |
Mikel Astiz |
13 years ago |
1 file, +11, -15 |
| 68b394a7 |
obexd: Fix possible unreplied D-Bus message
If a previous cancel request is in progress, a second cancel request
should fail.
This by the way fixes unreplied D-Bus messages. |
Mikel Astiz |
13 years ago |
1 file, +5, -0 |
| a9a5fcd7 |
obexd: Fix using org.openobex.Error
In addition use define so it is easier to change this in future |
Luiz Augusto von Dentz |
13 years ago |
7 files, +92, -85 |
| dc3076af |
obexd: Fix not using connection passed to obc_transfer_register
Make use of the connection parameter instead of assuming the connection
will always be to the session bus. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 2a7ec51f |
obexd: Rename Transfer interface to org.bluez.obex.Transfer |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -2 |
| e3d1b527 |
obexd: Rename MessageAccess interface to org.bluez.obex.MessageAccess |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| dea7c760 |
obexd: Rename Synchronization interface to org.bluez.obex.Synchronization |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 6ae17458 |
obexd: Rename PhonebookAccess interface to org.bluez.obex.PhonebookAccess |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 712f1126 |
obexd: Rename FileTransfer interface to org.bluez.obex.FileTransfer |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| f44090ba |
obexd: Update copyright statement |
Mikel Astiz |
13 years ago |
4 files, +4, -0 |
| 6793dfe0 |
obexd: ObjectPush sessions return transfers
Return the D-Bus path of the transfer representing the operation. |
Mikel Astiz |
13 years ago |
1 file, +13, -58 |
| 7d565a9c |
obexd: Rename session interface to org.bluez.obex.Session
The base is also changed to /org/bluez/obex to follow the new namespace |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -2 |
| f542d967 |
obexd: Rename ObjectPush interface to org.bluez.obex.ObjectPush |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 27a14618 |
obexd: Change namespace to org.bluez.obex.client |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -3 |
| 1ff927b7 |
obexd: Change agent interface to org.bluez.obex.Agent |
Luiz Augusto von Dentz |
13 years ago |
2 files, +4, -4 |
| d6ed7409 |
obexd: Change D-Bus namespace to org.bluez.obex
This changes the namespace from org.openobex to org.bluez.obex |
Luiz Augusto von Dentz |
13 years ago |
2 files, +19, -20 |
| 4b424100 |
obexd: PhonebookAccess sessions return transfers
Return the D-Bus path of the transfer representing the operation. |
Mikel Astiz |
13 years ago |
1 file, +75, -86 |
| 0a174f40 |
obexd: Synchronization sessions return transfers
Return the D-Bus path of the transfer representing the operation. |
Mikel Astiz |
13 years ago |
1 file, +33, -59 |
| d6f045dc |
obexd: FileTransfer sessions return transfers
Return the D-Bus path of the transfer representing the operation. |
Mikel Astiz |
13 years ago |
1 file, +14, -32 |
| d3b779a7 |
obexd: Expose D-Bus data in internal transfer API
Expose in transfer API the D-Bus path and properties as should be
returned by transfer-initiating D-Bus methods. |
Mikel Astiz |
13 years ago |
2 files, +54, -13 |
| b5fe20a9 |
obexd: Support empty filename in obc_transfer_get
Passing an empty string as a filename for obc_transfer_get will be
similar to passing a NULL filename. This means a temporary file will be
created to store the content of the transfer.
NULL and "" are not exactly equivalent though: in case of NULL the file
will be automatically removed immediately after being open, which means
that the transfer initiator should also open the file to prevent it from
being removed (to be used from the modules). In this case, the filename
will not be exposed in D-Bus.
On the other hand, if "" is given, the file will be removed only in case
of error. So after success the transfer initiator should decide whether
the file should be removed or not.
This change is convenient in order to expose the same API in D-Bus. |
Mikel Astiz |
13 years ago |
1 file, +22, -5 |
| c8ec529a |
obexd: Make transfer filename optional
The property might not exist for certain transfers, typically when they
have been initiated internally. |
Mikel Astiz |
13 years ago |
1 file, +3, -1 |
| eae9cf3d |
obexd: Make FileTransfer.PutFile asynchronous
There is no reason to have inconsistent behavior between GetFile and
PutFile, in FileTransfer D-Bus API.
Before this change, PutFile reported success immediately after queueing
the transfer, even though the D-Bus signature includes the async flag. |
Mikel Astiz |
13 years ago |
1 file, +8, -5 |
| febb9caf |
obexd: Add progress property to transfer
The number of transferred bytes is exposed in D-Bus using a specific
property for this purpose.
Internally, the value of this property does not necessarily match the
internal progress counter. In order to avoid D-Bus overhead, the
property will be updated once per second. |
Mikel Astiz |
13 years ago |
1 file, +64, -2 |
| 1b6d5d12 |
obexd: Replace SendFiles with SendFile
The function is now asynchronous, since it will return only when the
transfer has been finished. |
Mikel Astiz |
13 years ago |
1 file, +39, -27 |
| 649a3ffd |
obexd: Remove unused functions in transfer API
After the removal of the agent these functions are not useful any more. |
Mikel Astiz |
13 years ago |
2 files, +0, -26 |
| b91d4874 |
obexd: Expose all transfers in D-Bus
Relying on a internal policy (based on transfer type) to decide if a
transfer should be exposed or not in D-Bus has some limitations. The
simplest possible alternative to this is to expose all transfers in
D-Bus, assuming the overhead is not significant. |
Mikel Astiz |
13 years ago |
1 file, +0, -7 |
| b9f31ead |
obexd: Remove obsolete authentication code
After the removal of the agent, the implementation of the session can be
simplified by removing all authentication-related code. |
Mikel Astiz |
13 years ago |
1 file, +26, -60 |
| ef129dcc |
obexd: Remove internal transfer progress report
The new D-Bus API uses signals to report the progress updates, so the
internal progress callback is not needed any more. |
Mikel Astiz |
13 years ago |
3 files, +10, -36 |
| 5e3bc6b9 |
obexd: Remove D-Bus agent
The authorization mechanism is entirely removed from the session, and
thus transfers are automatically started (once popped from the queue)
without confirmation and without any name/filename change. |
Mikel Astiz |
13 years ago |
4 files, +2, -515 |
| 5119ebcc |
obexd: Use transfer owner instead of agent
The security checks in the transfers' D-Bus API will consider check for
the transfer owner's path (session owner) instead of the agent path. |
Mikel Astiz |
13 years ago |
3 files, +8, -13 |
| ce7b4cbd |
obexd: Add transfer event-reporting signals
These signals replace the old agent-based notification mechanism. |
Mikel Astiz |
13 years ago |
1 file, +21, -5 |
| 5ac5f18a |
obexd: Add D-Bus helper library
No functionality changes. This is just about avoiding duplicated code. |
Mikel Astiz |
13 years ago |
5 files, +338, -110 |
| 9250a662 |
obexd: Replace parameter dict with conventional ones |
Mikel Astiz |
13 years ago |
1 file, +14, -6 |
| 3d7cfa6c |
obexd: Move GetCapabilities to session API |
Mikel Astiz |
13 years ago |
2 files, +68, -121 |
| 0377b04b |
obexd: Wrap OPP into specific session type |
Mikel Astiz |
13 years ago |
2 files, +201, -262 |
| 8a1b3f32 |
obexd: Use constant instead of NULL variable
The filename will always be NULL for capability-requesting sessions, so
it doesn't make much sense to use such field. |
Mikel Astiz |
13 years ago |
1 file, +1, -2 |
| 0cbb1f10 |
obexd: Use stack memory for application parameters in pbap module
The maximum amount needed is known and sufficiently small to be in the
stack which is much simpler to deal with. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -3 |
| e39e821a |
obexd: Constify GDBus signal tables
Constify signal tables with the following command:
find . -name '*.[ch]' -exec \
sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \; |
Marcel Holtmann |
13 years ago |
1 file, +2, -2 |
| 65c66807 |
obexd: Remove left over glib-helper.h support |
Paul Seidler |
13 years ago |
2 files, +0, -2 |
| 80a93e2a |
obexd: Simplify error-handling code
Refactor error-handling code to avoid duplicated code. |
Mikel Astiz |
13 years ago |
1 file, +18, -30 |
| 1b0e0092 |
obexd: Fix NULL dereference in case of error
obc_session_queue assumes that the given transfer is not NULL, so this
must be checked explicitly. |
Mikel Astiz |
13 years ago |
1 file, +14, -2 |
| 9692e783 |
obexd: Do not set signature and reply in GDBus tables
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal. |
Lucas De Marchi |
13 years ago |
8 files, +47, -50 |
| d67b588d |
obexd: Convert GDBus methods to use macro helpers
With these macro helpers we can separate in/out arguments and use their
own vector. |
Lucas De Marchi |
13 years ago |
8 files, +127, -71 |
| fc009dd4 |
obexd: Constify GDBus method tables
Constify method tables with the following command:
find . -name '*.[ch]' -exec \
sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \; |
Marcel Holtmann |
13 years ago |
8 files, +10, -10 |
| 1282ed28 |
obexd: Fix not checking if GoepL2capPsm contains a valid PSM
In case the PSM is not valid ignore it so we are still able to connect
to RFCOMM. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -1 |
| b8c8567c |
obexd: Fix not setting port to 0 when listen fails
With some only kernels auto assigning psm seem to fail, leaving the psm
with wrong value:
obexd[2930]: plugins/bluetooth.c:start() listening on channel 9
obexd[2930]: bluetooth: unable to listen in psm 65535
obexd[2930]: plugins/bluetooth.c:start() listening on channel 10
obexd[2930]: bluetooth: unable to listen in psm 65535 |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -0 |
| fcd02ad5 |
obexd: Add obc_transfer_set_params to set application parameters
The parameters are optional and only used in a few occasions so it
doesn't make sense to have that directly in obc_transfer_get and
obc_transfer_put. |
Luiz Augusto von Dentz |
13 years ago |
7 files, +64, -68 |
| 9b883a02 |
obexd: Create transfers in modules
After this patch the modules are responsible for creating the transfers,
and these objects must be queued using the session API.
This way the transfer initiator has full access to the transfer object,
in case for example it wants to access some member variable. |
Mikel Astiz |
13 years ago |
7 files, +189, -211 |
| 02cc0066 |
obexd: Flip parameter order in transfer API
This minor change makes the transfer API more consistent with the
parameter-order used in the session API. |
Mikel Astiz |
13 years ago |
3 files, +10, -10 |