| 33b0aeda |
obexd: Fix freeing apparam data on PBAP module
Invalid read of size 8
at 0x40EC04: g_obex_apparam_free (gobex-apparam.c:362)
by 0x41A66A: obc_transfer_free (transfer.c:272)
by 0x413221: pending_request_free (session.c:163)
by 0x413659: session_terminate_transfer (session.c:745)
by 0x41A53E: xfer_complete (transfer.c:518)
by 0x41B5D7: get_xfer_progress_first (transfer.c:562)
by 0x409750: handle_response (gobex.c:948)
by 0x40A609: incoming_data (gobex.c:1191)
by 0x371D047824: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x371D047B57: ??? (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x371D047F51: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x40542F: main (main.c:175)
Address 0x4f64510 is 0 bytes inside a block of size 8 free'd
at 0x4A079AE: free (vg_replace_malloc.c:427)
by 0x371D04D50E: g_free (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x416060: phonebook_size_callback (pbap.c:266)
by 0x413651: session_terminate_transfer (session.c:743)
by 0x41A53E: xfer_complete (transfer.c:518)
by 0x41B5D7: get_xfer_progress_first (transfer.c:562)
by 0x409750: handle_response (gobex.c:948)
by 0x40A609: incoming_data (gobex.c:1191)
by 0x371D047824: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x371D047B57: ??? (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x371D047F51: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x40542F: main (main.c:175) |
Luiz Augusto von Dentz |
13 years ago |
1 file, +0, -2 |
| d77a6400 |
obexd: Add implementation for UpdateInbox |
Srinivasa Ragavan |
13 years ago |
1 file, +58, -0 |
| ea5d3841 |
obexd: Fix build when using --with-messages=tracker
Commit 15b15167fb2dd82e2189cc1955def1818a7bc6a6 broke the build:
plugins/messages.c:324:42: error: unknown type name ‘messages_update_inbox_cb’
plugins/messages.c:331:5: error: unknown type name ‘messages_set_read_cb’
plugins/messages.c:337:6: error: unknown type name ‘messages_set_delete_cb’ |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -3 |
| e24161f5 |
obexd: Unify callbacks for operations that only report status
This removes duplicated code. |
Luiz Augusto von Dentz |
13 years ago |
3 files, +9, -30 |
| f0f23558 |
obexd: Move common code to pull_phonebook |
Luiz Augusto von Dentz |
13 years ago |
1 file, +30, -49 |
| 3ab485ec |
obexd: Update the file offset to the beginning after writing to the file
When the transfer file is opened in O_RDWR mode, just after the contents are
written to the file, the file offset has to be set to the beginning of the
file. If not subsequent read fails. This patch fixes this. |
Srinivasa Ragavan |
13 years ago |
1 file, +1, -0 |
| 920bbb36 |
obexd: Add Message.SetProperty and Message.GetProperties implementation. |
Srinivasa Ragavan |
13 years ago |
1 file, +189, -0 |
| a103426e |
obexd: Make obc_transfer_put to accept NULL as filename
In that case contents should be valid so the modules can use
obc_transfer_put to create temporary files. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -1 |
| 36d387af |
obexd: Avoid extra copies while passing apparam to transfer
By passing directly the reference to GObexApparam it is no longer
necessary to use intermediate buffers to pass data around. |
Luiz Augusto von Dentz |
13 years ago |
4 files, +47, -99 |
| d1db67a3 |
obexd: Fix not sending parameters to get message in map module
Attachment and charset are mandatory, so Message.Get now takes an
additional boolean parameter which the user application should set
if it wants the attachments to be downloaded, charset is always set
to UTF8. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +19, -1 |
| 7eac4535 |
obexd: Add MessageAccess.ListFilterFields |
Luiz Augusto von Dentz |
13 years ago |
1 file, +39, -0 |
| 45779d1a |
obexd: Rename MessageAccess method GetMessagesListing to ListMessages
In addition to that add missing parsing of the filters |
Luiz Augusto von Dentz |
13 years ago |
1 file, +302, -15 |
| 16d0190e |
obexd: Rename MessageAccess method GetFolderListing to ListFolders
In addition to that add missing parsing of the filters. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +102, -7 |
| 0155c14f |
obexd: Use larger timeout first packet in transfers
This align the client timeout for GET operations with g_obex_get_req_pkt
which does use 60 seconds to cover for extra interaction during the first
packet. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +4, -1 |
| 9a117c33 |
obexd: Add set delete status function
This function will inform MAP server to modify
the delete status of a given message. |
Sunil Kumar Behera |
13 years ago |
4 files, +33, -0 |
| 31ef868b |
obexd: Add set read status function
This function will inform MAP server to modify the
read status of a given message. |
Sunil Kumar Behera |
13 years ago |
4 files, +50, -0 |
| 91b11b28 |
obexd: Add support for MessageStatus
Add driver to support x-bt/messageStatus mimetype |
Sunil Kumar Behera |
13 years ago |
1 file, +32, -1 |
| b338757c |
obexd: Make use of GObexApparam API |
Luiz Augusto von Dentz |
13 years ago |
1 file, +38, -43 |
| b3cd1f05 |
obexd: Add filters to Phonebook.PullAll
This avoid D-Bus round trips and is more aligned with what has been
proposed for MessageAccess interface. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +210, -46 |
| 1dbe451c |
obexd: Remove deprecated methods from PhonebookAccess
SetFormat, SetOrder, SetFilter and GetFilter methods are no longer
necessary as other methods now take them as parameters to avoid round
trips. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +14, -183 |
| 69048a06 |
obexd: Add filters to PhonebookAccess.List and PhonebookAccess.Search
This avoid D-Bus round trips and is more aligned with what has been
proposed for MessageAccess interface. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +76, -39 |
| 6db22701 |
obexd: Add filters to PhonebookAccess.Pull
This avoid D-Bus round trips and is more aligned with what has been
proposed for MessageAccess interface. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +52, -26 |
| 3b9daaaf |
obexd: Fix crash on map module
gboolean is expected to hold 0/1. But it is holding int return from
strcasecmp which crashes DBusMessage at:
_dbus_return_val_if_fail (*bool_p == 0 || *bool_p == 1, FALSE);
Trace:
0 0x00007ffff7328d95 in __GI_raise (sig=6) at raise.c:64
1 0x00007ffff732a2ab in __GI_abort () at abort.c:93
2 0x00007ffff78d0655 in _dbus_abort () at dbus-sysdeps.c:94
3 0x00007ffff78c75f1 in _dbus_warn_check_failed at dbus-internals.c:289
4 0x00007ffff78ba28b in dbus_message_iter_append_basic at dbus-message.c:2538
5 0x00000000004201c3 in append_variant at client/dbus.c:44
6 0x000000000042024e in obex_dbus_dict_append at client/dbus.c:65
7 0x000000000041dcc9 in parse_read at client/map.c:423
8 0x000000000041dfa7 in msg_element at client/map.c:518
9 0x00007ffff7b323b9 in emit_start_element at gmarkup.c:986
10 0x00007ffff7b33b44 in g_markup_parse_context_parse at gmarkup.c:1323
11 0x000000000041e1ad in message_listing_cb at client/map.c:586
12 0x000000000041744c in session_terminate_transfer client/session.c:743
13 0x00000000004174d7 in session_notify_complete at client/session.c:758
14 0x000000000041755a in transfer_complete at client/session.c:778
15 0x000000000041f57b in xfer_complete at client/transfer.c:521
16 0x000000000040efdf in transfer_complete at gobex/gobex-transfer.c:102
17 0x000000000040f418 in transfer_response at gobex/gobex-transfer.c:221
18 0x000000000040b320 in handle_response at gobex/gobex.c:948
19 0x000000000040bbc1 in incoming_data at gobex/gobex.c:1191
20 0x00007ffff7b2f94a in g_main_dispatch (context=0x62f130) at gmain.c:2515
21 g_main_context_dispatch (context=0x62f130) at gmain.c:3052
22 0x00007ffff7b2fd10 in g_main_context_iterate at gmain.c:3123
23 g_main_context_iterate at gmain.c:3060
24 0x00007ffff7b3010a in g_main_loop_run (loop=0x62e1b0) at gmain.c:3317
25 0x000000000041527d in main at client/main.c:175 |
Srinivasa Ragavan |
13 years ago |
1 file, +4, -4 |
| d860754d |
obexd: Remove redundant include errno.h |
Syam Sidhardhan |
13 years ago |
1 file, +0, -1 |
| 139ca837 |
obexd: Remove redundant include sys/stat.h |
Syam Sidhardhan |
13 years ago |
1 file, +0, -1 |
| c00b7b22 |
obexd: Add subject length parameter in GetMessageListing
Add subject length parameter to allow MAP server to
create subject as per MAP client length preference. |
Sunil Kumar Behera |
13 years ago |
4 files, +11, -3 |
| 134bcbcc |
obexd: Add offset parameter decription
Add offset parameter description for
messages_get_messages_listing() function header |
Sunil Kumar Behera |
13 years ago |
1 file, +1, -0 |
| a558890e |
obexd: Fix invalid oflag check
Change logic to check for O_WRONLY, as oflag is
created by an OR operation of O_WRONLY, O_CREAT and
O_TRUNC.
Message update is a PUT function, this check returns
bad response if GET is received. |
Sunil Kumar Behera |
13 years ago |
1 file, +1, -1 |
| c7523cb9 |
obexd: Remove map_ap.c
It is no longer needed as MAP plugin is now using GObexApparam API |
Luiz Augusto von Dentz |
13 years ago |
2 files, +0, -529 |
| 398d3e23 |
obexd: Make use of GObexApparam API |
Luiz Augusto von Dentz |
13 years ago |
2 files, +39, -143 |
| eb3aaa4d |
obexd: Port PBAP module to use GObexApparam |
Luiz Augusto von Dentz |
13 years ago |
1 file, +49, -132 |
| 20340654 |
obexd: Fix error returning in obc_transfer_put
Always set error on failure in obc_transfer_put. This is expected by
callers and will avoid possible NULL pointer dereference.
Also fix improper use of errno variable (calling error may modify it)
and some dead assignments to perr. |
Szymon Janc |
13 years ago |
1 file, +10, -7 |
| 527cf79f |
obexd: Fix possible memory leak in handling of location
path was not being freed before returning, the is also simplified so
the error is now given in the return of the function. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +28, -29 |
| 57015dac |
obexd: Fix phonebook contacts query
At the moment IRMC fails to connect for phonebook_ebook and
phonebook_tracker usage because the name parameter for phonebook_pull
is not an absolute path. |
Harald Schmitt |
13 years ago |
1 file, +2, -2 |
| 789eb492 |
obexd: Fix pbap_select using absolute path with known locations
pbap_select has to use absolute path with known location to support
repeatable pbap_select calls. In other way the second call fails. |
Ludek Finstrle |
13 years ago |
1 file, +2, -2 |
| ee215d60 |
obexd: Fix possible memory leak in bluetooth driver
2,210 (64 direct, 2,146 indirect) bytes in 2 blocks are definitely lost in loss record 150 of 155
at 0x4A0884D: malloc (vg_replace_malloc.c:263)
by 0x3B2900F8A1: sdp_create (sdp.c:3656)
by 0x3B2900FAE0: sdp_connect (sdp.c:4604)
by 0x415902: adapter_reply (bluetooth.c:421)
by 0x3B22C0C429: ??? (in /usr/lib64/libdbus-1.so.3.5.6)
by 0x3B22C0F5E9: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.5.6)
by 0x4059A7: message_dispatch (mainloop.c:76)
by 0x32CD64822A: ??? (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x32CD647694: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x32CD6479C7: ??? (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x32CD647DC1: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x40567F: main (main.c:175) |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -0 |
| 62ebf8d0 |
obexd: Make handle of location more clear
Add proper defines for supported paths and convert relative
path absolute to align with PBAP paths. |
Luiz Augusto von Dentz |
13 years ago |
2 files, +85, -78 |
| a806141e |
obexd: phonebook: Replace magic strings for phonebook names and folders |
Harald Schmitt |
13 years ago |
4 files, +46, -33 |
| 96e59fff |
obexd: Add Message.Get implementation |
Luiz Augusto von Dentz |
13 years ago |
1 file, +37, -0 |
| 535a6589 |
obexd: Use filter instead of dummy as argument name in MAP
This is aligned with the documentation that uses filter as well. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -2 |
| 9ac5d05a |
obexd: Change MessageAccess.GetMessageListing to not return raw xml
This parses the response and return as a list of dictionary where each
entry is a message and its properties, |
Luiz Augusto von Dentz |
13 years ago |
1 file, +369, -37 |
| 3471e476 |
obexd: Change MessageAccess.GetFolderListing to not return raw xml
This parses the response and return as a list of dictionary where each
entry is a folder and its properties, similar to what
FileTransfer.ListFolder does. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +86, -2 |
| 0acb3455 |
obexd: Fix wrong signature of MessageAccess.SetFolder
D-Bus string signature is 's' not 'string' |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 2d07cea3 |
obexd: Fix some common spelling errors
Fix spelling errors reported by codespell. |
Szymon Janc |
13 years ago |
4 files, +5, -5 |
| 84c4c3be |
obexd: Fix dead assignments
Values stored are never read. |
Szymon Janc |
13 years ago |
3 files, +3, -3 |
| 9d13a708 |
obexd: Fix cancellation of queued transfers
Cancelling queued (not started yet) transfers should not fail. Instead,
they must be removed from the queue, so we just need to call the
transfer callback. |
Mikel Astiz |
13 years ago |
1 file, +14, -4 |
| 8a296cfc |
obexd: Use session path as prefix for transfer path
This should make it easier to identify to which session the transfer
belongs. |
Luiz Augusto von Dentz |
13 years ago |
3 files, +5, -5 |
| e1713aa1 |
obexd: Use g_malloc0 in get_filter_strs
Use g_malloc0 instead of g_try_malloc0 to allocate list. All users
expects to get valid pointer from it anyway. Also size of allocated
memory is small. |
Szymon Janc |
13 years ago |
1 file, +1, -4 |
| bd8e8431 |
obexd: Fix use of uninitialized count variable
If opendir() call fails count would be passed to callback
uninitialized. |
Szymon Janc |
13 years ago |
1 file, +1, -1 |
| a5524f59 |
obexd: Fix memory leak in bluetooth driver
384 (184 direct, 200 indirect) bytes in 1 blocks are definitely lost in loss record 141 of 157
at 0x4A0884D: malloc (vg_replace_malloc.c:263)
by 0x392E217815: ??? (in /usr/lib64/libdbus-1.so.3.5.6)
by 0x392E218632: dbus_message_new_method_call (in /usr/lib64/libdbus-1.so.3.5.6)
by 0x413AD3: send_method_call (bluetooth.c:87)
by 0x414933: manager_reply (bluetooth.c:496)
by 0x392E20C429: ??? (in /usr/lib64/libdbus-1.so.3.5.6)
by 0x392E20F5E9: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.5.6)
by 0x405767: message_dispatch (mainloop.c:76)
by 0x369E04827A: ??? (in /usr/lib64/libglib-2.0.so.0.3200.3)
by 0x369E0476E4: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3200.3)
by 0x369E047A17: ??? (in /usr/lib64/libglib-2.0.so.0.3200.3)
by 0x369E047E11: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3200.3) |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -0 |