| 0416930e |
obexd: Use pending request in UpdateInbox |
Christian Fetzer |
12 years ago |
1 file, +10, -7 |
| 1852ab4e |
obexd: Use pending request in ListMessages |
Christian Fetzer |
12 years ago |
1 file, +17, -12 |
| 0b74a2e0 |
obexd: Use pending request in ListFolders |
Christian Fetzer |
12 years ago |
1 file, +14, -9 |
| 0c182183 |
obexd: Use pending request in SetFolder |
Christian Fetzer |
12 years ago |
1 file, +9, -7 |
| 762d5239 |
obexd: Add request struct to MAP
This adds a pending_request struct in order to store the D-Bus request
data.
The current version stores the received D-Bus message in the MAP session
struct. The stored message is overridden by intermediate D-Bus method
calls which can lead into a crash.
Trace:
arguments to dbus_message_unref() were incorrect,
assertion "!message->in_cache" failed in file dbus-message.c line 1618.
0 0x00007ffff6a6a1c9 in raise () from /usr/lib/libc.so.6
1 0x00007ffff6a6b5c8 in abort () from /usr/lib/libc.so.6
2 0x00007ffff7313de5 in ?? () from /usr/lib/libdbus-1.so.3
3 0x00007ffff730ab91 in ?? () from /usr/lib/libdbus-1.so.3
4 0x000000000043721c in message_listing_cb (session=0x6a7d30,
transfer=0x6a9450, err=0x0, user_data=0x6a9950) at obexd/client/map.c:1166
5 0x000000000042f7af in session_terminate_transfer (session=0x6a7d30,
transfer=0x6a9450, gerr=0x0) at obexd/client/session.c:830
6 0x000000000042f83d in session_notify_complete (session=0x6a7d30,
transfer=0x6a9450) at obexd/client/session.c:845
7 0x000000000042f8dc in transfer_complete (transfer=0x6a9450, err=0x0,
user_data=0x6a7d30) at obexd/client/session.c:865
8 0x0000000000439ee7 in xfer_complete (obex=0x677250, err=0x0,
user_data=0x6a9450) at obexd/client/transfer.c:577
9 0x000000000043a05f in get_xfer_progress_first (obex=0x677250, err=0x0,
rsp=0x678730, user_data=0x6a9450) at obexd/client/transfer.c:621
10 0x0000000000413f08 in handle_response (obex=0x677250, err=0x0,
rsp=0x678730) at gobex/gobex.c:949
11 0x00000000004147db in incoming_data (io=0x6a8a00, cond=G_IO_IN,
user_data=0x677250) at gobex/gobex.c:1192
12 0x00007ffff702dda6 in g_main_context_dispatch ()
from /usr/lib/libglib-2.0.so.0
13 0x00007ffff702e0f8 in ?? () from /usr/lib/libglib-2.0.so.0
14 0x00007ffff702e4fa in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
15 0x0000000000427ce8 in main (argc=1, argv=0x7fffffffdd48)
at obexd/src/main.c:319 |
Christian Fetzer |
12 years ago |
1 file, +24, -0 |
| 2a147a61 |
core: Remove legacy parsing of OUI database |
Marcel Holtmann |
12 years ago |
1 file, +1, -67 |
| 55afc94e |
sap: Keep reference to btd_adapter in struct sap_server
Path and adapter address can be obtained easily from btd_adapter
and there is no need to keep local copy. |
Szymon Janc |
12 years ago |
3 files, +16, -15 |
| d8b739b2 |
core: Minor whitespace fix |
Szymon Janc |
12 years ago |
1 file, +4, -4 |
| 3eb98cd4 |
gitignore: Add tools/btinfo |
Szymon Janc |
12 years ago |
1 file, +1, -0 |
| 85d61d3e |
obexd: Use documented values in org.bluez.obex.Message1 Type property
This updates the values that are presented in the Type property to use
the values from the documentation ("email", "sms-gsm", "sms-cdma", "mms").
The existing code directly used the values as received in the messages
listing object ("EMAIL", "SMS_GSM", "SMS_CDMA", "MMS"). |
Christian Fetzer |
12 years ago |
1 file, +11, -1 |
| dda571b9 |
shared/hciemu: Fix sending a proper vhci create request for new kernels |
Johan Hedberg |
12 years ago |
1 file, +14, -0 |
| 5c6eb25d |
gdbus/client: Use g_dbus_add_properties_watch to track properties
This make the handling much simpler and avoids duplicates of the same
match rule. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +56, -79 |
| 311c01f5 |
gdbus/client: Use g_dbus_add_signal_watch to track signals
This make the handling much simpler and avoids duplicates of the same
match rule. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +37, -36 |
| 02f3690b |
gdbus/client: Use g_dbus_add_service_watch to track services
This make the handling much simpler and avoids duplicates of the same
match rule. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +38, -135 |
| 842080fd |
gdbus/watch: Fix crash when disconnecting from D-Bus
When disconnecting from D-Bus a message could be recieved with no sender:
Invalid read of size 1
at 0x4A09EE1: strcmp (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x3B03C386B8: g_str_equal (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x4065D6: message_filter (watch.c:529)
by 0x3B0700F9E5: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.7.4)
by 0x4052E7: message_dispatch (mainloop.c:76)
by 0x3B03C48962: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3B03C47E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3B03C48157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3B03C48559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x4038C5: client_proxy_removed (test-gdbus-client.c:902)
by 0x3B03C6B566: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3B03C6B6E5: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
Address 0x0 is not stack'd, malloc'd or (recently) free'd |
Luiz Augusto von Dentz |
12 years ago |
1 file, +2, -0 |
| a2ca06f2 |
gdbus/watch: Fix aborting when removing D-Bus filter
In case of filter_data having a watch to a service name it may call
dbus_connection_remove_filter twice causing libdbus to abort:
process 24723: Attempt to remove filter function 0x4063e0 user data (nil), but no such filter has been added
To fix this the code will now only attempt to call
dbus_connection_remove_filter once in filter_data_free which is the
counterpart of filter_data_get where dbus_connection_add_filter is called. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +8, -17 |
| 759819db |
gdbus/watch: Fix crash when g_dbus_remove_watch is called from connect callback
at 0x40570C: update_service (watch.c:601)
by 0x40584B: service_reply (watch.c:627)
by 0x3B0700C511: ??? (in /usr/lib64/libdbus-1.so.3.7.4)
by 0x3B0700F740: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.7.4)
by 0x405167: message_dispatch (mainloop.c:76)
by 0x3B03C48962: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3B03C47E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3B03C48157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3B03C48559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)
Address 0x4c58a30 is 32 bytes inside a block of size 56 free'd
at 0x4A074C4: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x3B03C4D9AE: g_free (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x406102: filter_data_remove_callback (watch.c:378)
by 0x405FC0: g_dbus_remove_watch (watch.c:798)
by 0x40A22B: g_dbus_client_unref (client.c:1227)
by 0x40570B: update_service (watch.c:599)
by 0x40584B: service_reply (watch.c:627) |
Luiz Augusto von Dentz |
12 years ago |
1 file, +6, -2 |
| 194360a4 |
unit: Add gdbus/client_force_disconnect
This tests if watches created using g_dbus_proxy_set_removed_watch works
when the service disconnects from the bus. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +59, -0 |
| 90f13d30 |
unit: Add gdbus/client_proxy_removed
This tests if watches created using g_dbus_proxy_set_removed_watch works
when the interface is removed. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +57, -0 |
| aef08344 |
monitor: Add missing include
Bionic library requires explicit include for data types used in ioctl
call. This fix following build error with bionic:
target C: btmon <= external/bluetooth/bluez/monitor/display.c
external/bluetooth/bluez/monitor/display.c: In function 'num_columns':
external/bluetooth/bluez/monitor/display.c:59:18: error: storage size
of 'ws' isn't known |
Szymon Janc |
12 years ago |
1 file, +1, -0 |
| 8a4ab291 |
profile: Remove support for Cancel method |
Denis Kenzior |
12 years ago |
1 file, +0, -18 |
| 4c055aff |
doc: Remove Profile1.Cancel() method
There does not seem to be any actual need for this method.
The current implementation calls Cancel when a pending
NewConnection() or RequestDisconnection() method call fails.
Additionally it calls Cancel() when the remote client has disconnected.
In either case BlueZ calls shutdown on the file descriptor associated
with the agent and issues a Cancel() method call.
The closing of the file descriptor will trigger a HUP on the agent side,
which will trigger normal cleanup procedures. The received Cancel()
method call is redundant in both cases. |
Denis Kenzior |
12 years ago |
1 file, +0, -8 |
| 6402393a |
doc: Label Profile1.Release() method as no reply
The current implementation does not expect a reply, nor would it make
sense for BlueZ to wait for one from the agent. So explicitly label
this method as noreply. |
Denis Kenzior |
12 years ago |
1 file, +1, -1 |
| 6e4efa23 |
avdtp: Remove unused STREAM_TIMEOUT define |
Szymon Janc |
12 years ago |
1 file, +0, -1 |
| 22cba038 |
avdtp: Remove not used includes |
Szymon Janc |
12 years ago |
1 file, +0, -3 |
| 4be1934f |
avdtp: Remove not used pending_auth from struct avdtp |
Szymon Janc |
12 years ago |
1 file, +2, -9 |
| eb907a19 |
shared: Check HCI packet type before sending it to btdev |
Marcel Holtmann |
12 years ago |
1 file, +8, -2 |
| c64fd378 |
codingstyle: Change __FUNCTION__ to __func__
The __func__ macro is part of the C99 standard whereas __FUNCTION__ is a
legacy gcc specific alias for it:
http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html
Additionally, checkpatch.pl that's commonly used to verify coding style
also recommends to use __func__ instead of __FUNCTION__. |
Andrei Emeltchenko |
12 years ago |
4 files, +4, -4 |
| 84a07386 |
emulator: Add missing HCI commands to the supported commands response |
Johan Hedberg |
12 years ago |
1 file, +14, -0 |
| d87776a2 |
emulator: Disallow SCO HCI commands on LE-only controllers |
Johan Hedberg |
12 years ago |
1 file, +4, -0 |
| 4b95a69b |
emulator: Disallow HCI_Write_Current_IAP_LAP for LE-only controllers |
Johan Hedberg |
12 years ago |
1 file, +2, -0 |
| aa6c7278 |
emulator: Add support for reading local out-of-band data |
Marcel Holtmann |
12 years ago |
1 file, +8, -0 |
| 9a968090 |
emulator: Add options to usage description |
Marcel Holtmann |
12 years ago |
1 file, +3, -0 |
| 18ce6878 |
obexd/bluetooth: Fix error on register_profile
The error happens whenever RegisterProfile fails the interface is not
unregistered causing any subsequent call to register_profile function
to fail:
obexd[944]: D-Bus failed to register /org/bluez/obex/00005005_0000_1000_8000_0002ee000001
obexd[944]: bluetooth: Failed to register profile (null) |
Luiz Augusto von Dentz |
12 years ago |
1 file, +9, -10 |
| cfb34d25 |
build: Check for clock_gettime with -lrt |
Marcel Holtmann |
12 years ago |
2 files, +1, -2 |
| 6972187a |
obexd: Make use of g_dbus_send_message*
This replaces dbus_connection_send* with g_dbus_send_message* which do
not alter message order. |
Luiz Augusto von Dentz |
12 years ago |
4 files, +7, -9 |
| 8bcf8f1c |
audio/media: Make use of g_dbus_send_message_with_reply
This replaces dbus_connection_send_with_reply with
g_dbus_send_message_with_reply which does not alter message order. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +1, -1 |
| 92d13216 |
neard: Make use of g_dbus_send_message_with_reply
This replaces dbus_connection_send_with_reply with
g_dbus_send_message_with_reply which does not alter message order. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +1, -1 |
| c0e939db |
core: Make use of g_dbus_send_message_with_reply
This replaces dbus_connection_send_with_reply with
g_dbus_send_message_with_reply which does not alter message order. |
Luiz Augusto von Dentz |
12 years ago |
2 files, +8, -8 |
| 2ed51977 |
gdbus: Fix emitting PropertiesChanged twice
This fixes double emission of PropertiesChanged introduced by flushing
changes, the flushing can happen during the pending processing so the
pending_prop flag needs to be updated in the beginning and the list of
properties can be freed before g_dbus_send_message as it is not required
anymore. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +2, -2 |
| c77003af |
gdbus: Avoid calling dbus_connection_send*
dbus_connection_send* should not be called directly except by
g_dbus_send_message. |
Luiz Augusto von Dentz |
12 years ago |
2 files, +42, -64 |
| 321d17f3 |
gdbus: Add g_dbus_send_message_with_reply
g_dbus_send_message_with_reply flushes pending signals before calling
dbus_connection_send_with_reply so it does not alter the message order |
Luiz Augusto von Dentz |
12 years ago |
2 files, +14, -0 |
| 8c43713d |
gdbus: Fix sending ObjectManager/Properties signals out of order
In some cases the order of the messages is altered when a message is
sent without processing the pending signals first, currently this affect
client_check_order unit test:
/gdbus/client_check_order: **
ERROR:unit/test-gdbus-client.c:795:property_check_order: assertion failed: (g_strcmp0(string, "value1") == 0)
As can be observed the value of the property is not yet updated because the
signal it is still pending, once this fix is applied the test pass:
/gdbus/client_check_order: OK
Note that the flushing only works when g_dbus_send_message is used so
places where dbus_connection_send and other variants are called directly
may still change the order. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +53, -16 |
| 5cd3828d |
unit: Add gdbus/client_check_order |
Luiz Augusto von Dentz |
12 years ago |
1 file, +71, -0 |
| 1cc4f9cc |
build: Fix not rebuilding bluetoothd if gdbus changes
src_bluetoothd_DEPENDENCIES should list all local libraries including gdbus
otherwise it does not get relinked whenever gdbus changes. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +1, -1 |
| aaf02e48 |
sco-tester: Update ECONNABORTED to EOPNOTSUPP
Kernel interface has evolved in between. |
Frédéric Dalleau |
12 years ago |
1 file, +1, -1 |
| 85e6cc2d |
monitor: Decode page scan and page scan period mode commands |
Marcel Holtmann |
12 years ago |
1 file, +42, -4 |
| 3482d821 |
monitor: Add definitions for page scan and page scan period mode |
Marcel Holtmann |
12 years ago |
1 file, +22, -0 |
| 470be824 |
monitor: Add more details to Set Event Filter decoding |
Marcel Holtmann |
12 years ago |
1 file, +77, -2 |
| 52992076 |
monitor: Add decoding for number of supported IAC command |
Marcel Holtmann |
12 years ago |
1 file, +11, -1 |