| 5cbc2e68 |
obexd/service: Remove unused local variable
This fix following build error:
CC obexd/src/obexd-service.o
obexd/src/service.c: In function ‘obex_service_driver_register’:
obexd/src/service.c:100:10: error: unused variable ‘l’ [-Werror=unused-variable] |
Szymon Janc |
12 years ago |
1 file, +0, -2 |
| bce50703 |
obexd: Return "error" for unknown status in status2str
This can happend only if there is a bug in obexd code.
This fix following buld error:
CC obexd/src/obexd-manager.o
obexd/src/manager.c: In function ‘status2str’:
obexd/src/manager.c:292:1: error: control reaches end of non-void
function [-Werror=return-type] |
Szymon Janc |
12 years ago |
1 file, +1, -0 |
| c8f07de4 |
obexd: Remove unused local variables
This fix following build errors:
obexd/src/manager.c: In function ‘get_root’:
obexd/src/manager.c:253:23: error: unused variable ‘os’
[-Werror=unused-variable]
obexd/src/manager.c: In function ‘manager_emit_transfer_started’:
obexd/src/manager.c:534:22: error: unused variable ‘id’
[-Werror=unused-variable]
obexd/src/manager.c: In function ‘manager_request_authorization’:
obexd/src/manager.c:684:14: error: unused variable ‘type’
[-Werror=unused-variable]
obexd/src/manager.c:683:14: error: unused variable ‘filename’
[-Werror=unused-variable] |
Szymon Janc |
12 years ago |
1 file, +0, -5 |
| f3a0cd30 |
obexd: Remove unused static functions
This fix following build error:
obexd/src/manager.c: At top level:
obexd/src/manager.c:190:13: error:
‘dbus_message_iter_append_dict_entry’ defined but not used
[-Werror=unused-function] |
Szymon Janc |
12 years ago |
1 file, +0, -75 |
| d606c252 |
obexd/MAP: Remove unused mas_drivers variable
This fix following build error:
CC obexd/client/obexd-mns.o
obexd/client/mns.c:344:38: error: ‘mas_drivers’ defined but not used
[-Werror=unused-variable]
cc1: all warnings being treated as errors |
Szymon Janc |
12 years ago |
1 file, +0, -5 |
| 21d3b9c3 |
obexd/MAP: Fix missing include
This fix following build error:
CC obexd/client/obexd-mns.o
obexd/client/mns.c: In function ‘parse_event_report_handle’:
obexd/client/mns.c:187:2: error: implicit declaration of function
‘strtoull’ [-Werror=implicit-function-declaration] |
Szymon Janc |
12 years ago |
1 file, +1, -0 |
| fcc8b020 |
obexd/MAP: Fix missing include
This fix following build error:
CC obexd/client/obexd-mns.o
obexd/client/mns.c: In function ‘mns_connect’:
obexd/client/mns.c:105:2: error: implicit declaration of function
‘manager_register_session’ [-Werror=implicit-function-declaration]
obexd/client/mns.c: In function ‘mns_disconnect’:
obexd/client/mns.c:128:2: error: implicit declaration of function
‘manager_unregister_session’ [-Werror=implicit-function-declaration] |
Szymon Janc |
12 years ago |
1 file, +2, -0 |
| a78dae82 |
obexd/bluetooth: Make dict_append_entry function static
This fix following build error:
CC obexd/plugins/obexd-bluetooth.o
obexd/plugins/bluetooth.c:242:6: error: no previous declaration for
‘dict_append_entry’ [-Werror=missing-declarations] |
Szymon Janc |
12 years ago |
1 file, +1, -1 |
| d0b3d72f |
obexd/bluetooth: Remove unused local variables
This ix following build errors:
CC obexd/plugins/obexd-bluetooth.o
obexd/plugins/bluetooth.c: In function ‘register_profile_reply’:
obexd/plugins/bluetooth.c:202:10: error: unused variable ‘err’
[-Werror=unused-variable]
obexd/plugins/bluetooth.c: In function ‘name_acquired’:
obexd/plugins/bluetooth.c:367:15: error: unused variable ‘uuid’
[-Werror=unused-variable]
obexd/plugins/bluetooth.c: In function ‘name_released’:
obexd/plugins/bluetooth.c:389:15: error: unused variable ‘uuid’
[-Werror=unused-variable]
obexd/plugins/bluetooth.c: In function ‘bluetooth_start’:
obexd/plugins/bluetooth.c:400:10: error: unused variable ‘ios’
[-Werror=unused-variable] |
Szymon Janc |
12 years ago |
1 file, +0, -4 |
| c1ab9163 |
obexd/MAP: Fix invalid snprintf format string in map_msg_get()
obexd/client/map.c: In function ‘map_msg_get’:
obexd/client/map.c:446:2: warning: format ‘%u’ expects argument of type
‘unsigned int’, but argument 4 has type ‘uint64_t’ [-Wformat]
obexd/client/map.c:446:2: warning: format ‘%u’ expects argument of type
‘unsigned int’, but argument 4 has type ‘uint64_t’ [-Wformat] |
Szymon Janc |
12 years ago |
1 file, +1, -1 |
| 603eb343 |
doc: Correct a few minor style issues |
Marcel Holtmann |
12 years ago |
1 file, +5, -4 |
| aaa9c1db |
doc: Add missing title text to static address command |
Marcel Holtmann |
12 years ago |
1 file, +2, -2 |
| de40e1d3 |
obexd/MAP: Store message handle in binary format
This is more efficient in terms of memory and hash lookups, it is also
not prone to string format bugs in remote stacks such as leading zeros
being treated as a different handle as can be experience with
Nokia N950 which sends events using a handle with leading zeros but
message listing don't have them. |
Luiz Augusto von Dentz |
12 years ago |
4 files, +35, -23 |
| 27bb25c1 |
obexd/session: Fix crash while processing command queue
session_process_queue can call a callback which can cause the session to
be freed:
Invalid write of size 4
at 0x4265C9: session_process (session.c:716)
by 0x3D46047E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3D46048157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3D46048559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x40D55C: main (main.c:319)
Address 0x4d658a8 is 104 bytes inside a block of size 120 free'd
at 0x4A074C4: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x3D4604D9AE: g_free (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x4265B1: session_process_queue (session.c:794)
by 0x4265C8: session_process (session.c:714)
by 0x3D46047E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3D46048157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x3D46048559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)
by 0x40D55C: main (main.c:319) |
Luiz Augusto von Dentz |
12 years ago |
1 file, +2, -2 |
| 8b6966a7 |
obexd: Prefix folders in event reports with leading slash
The internal representation of folder paths starts with a leading slash.
Therefore we have to prepend it to the folders received in event reports. |
Christian Fetzer |
12 years ago |
1 file, +14, -2 |
| c55ebae4 |
obexd: Handle message shift and message deleted events
Update Folder propery if the message has been shifted or deleted. |
Christian Fetzer |
12 years ago |
1 file, +29, -0 |
| 85bf0046 |
obexd: Update Status property in map documentation
For outgoing messages, the status field values are:
"delivery-success", "sending-success", "delivery-failure", "sending-failure" |
Christian Fetzer |
12 years ago |
1 file, +7, -3 |
| 0e346308 |
obexd: Handle message status events
For outgoing messages, the message status is changed when an event
indicates that the sending/delivery has failed or succeeded. |
Christian Fetzer |
12 years ago |
1 file, +31, -0 |
| d4d2b1a1 |
obexd: Handle new message event
Register new org.bluez.obex.Message1 D-Bus object when a NewMessage
event report has arrived. |
Christian Fetzer |
12 years ago |
1 file, +49, -25 |
| 9debd78b |
tools/l2cap-tester: Make setup_powered_server() enable LE advertising when necessary |
Johan Hedberg |
12 years ago |
1 file, +2, -0 |
| a98b1807 |
tools/l2cap-tester: Rename generic test_bredr_server() to test_server() |
Johan Hedberg |
12 years ago |
1 file, +6, -8 |
| 82574c4f |
tools/l2cap-tester: Fix passing correct psm to create_l2cap_sock() |
Johan Hedberg |
12 years ago |
1 file, +1, -1 |
| 1faed0b2 |
tools/l2cap-tester: Separate server and client setup routines |
Johan Hedberg |
12 years ago |
1 file, +50, -16 |
| f203ef5e |
tools/l2cap-tester: Add LE support |
Johan Hedberg |
12 years ago |
1 file, +54, -22 |
| 7c6ab2ca |
bnep: improve error-msg if bnep.ko is not loaded
bnep.ko, besides others, can be disabled in custom kernels if
network-support is not required. To avoid strange error messages, handle
EPROTONOSUPPORT as a special case and emit a warning that kernel support
is missing. |
David Herrmann |
12 years ago |
2 files, +14, -4 |
| e7f623e0 |
plugin: handle ENOSYS as not-supported
Allow plugins to return -ENOSYS during registration and handle it as
"not-supported" error. It makes the error messages slightly more useful in
case kernel-support is missing for a particular subsystem. |
David Herrmann |
12 years ago |
1 file, +10, -3 |
| c287f304 |
monitor: Fail on invalid command line parameters |
Marcel Holtmann |
12 years ago |
1 file, +5, -0 |
| d5bd1b14 |
monitor: Use different tables for BR/EDR and LE L2CAP signal channels |
Marcel Holtmann |
12 years ago |
1 file, +92, -9 |
| cea02ba8 |
doc/mgmt-api: Add definition for Set Static Address |
Johan Hedberg |
12 years ago |
1 file, +27, -0 |
| a1fa0a3b |
tools/btmgmt: Fix small copy&paste issue |
Marcel Holtmann |
12 years ago |
1 file, +1, -1 |
| 84beb3c0 |
tools/btmgmt: Add support for setting static address |
Marcel Holtmann |
12 years ago |
1 file, +41, -0 |
| ea0fa83e |
lib: Add define for mgmt_set_static_address |
Marcel Holtmann |
12 years ago |
1 file, +6, -0 |
| f49000fe |
tools/mgmt-tester: Fix expected response code for start_discovery case |
Johan Hedberg |
12 years ago |
1 file, +1, -1 |
| 4d96b9be |
obexd: Fix emitting Type property changed signals for messages
In order to determine if the message Type property has changed,
the stored type needs to be compared with the parsed type and not with
the raw value received from the MSE.
This fixes the issue that the property changed signal for the Type
property is emitted for every message on every ListMessage call. |
Christian Fetzer |
12 years ago |
1 file, +11, -10 |
| 15954a45 |
sdp: Check for correct pkt size received instead of error
Check that the full header is received in recv(). |
Andrei Emeltchenko |
12 years ago |
1 file, +1, -1 |
| fd8d0713 |
lib: Fix invalid "whitespace" on company identifier string
Somehow, the invalid multibyte sequence "\xC2\xA0" (which is displayed
as a whitespace) was inserted on a company identifier string. Fix this
to avoid a bogus diff when running tools/update_compids.sh. |
Anderson Lizardo |
12 years ago |
1 file, +1, -1 |
| 703f2517 |
tools: Fix update_compids.sh to avoid non-ASCII output
Some distros have html2text patches that may generate non-ASCII output
even when -ascii is used. This patch adds another case (seen in Fedora)
where HTML entity   (non-breaking space) is converted into a
multibyte whitespace.
Also add a sanity check to make sure non-ASCII text is not introduced in
lib/bluetooth.c. |
Anderson Lizardo |
12 years ago |
1 file, +13, -4 |
| a29602bc |
doc: Small beautification |
Marcel Holtmann |
12 years ago |
1 file, +1, -1 |
| 87fc18fe |
tools/mgmt-tester: Add some basic set_bredr set cases |
Johan Hedberg |
12 years ago |
1 file, +124, -0 |
| 516007fa |
tools/btmgmt: Add support for set_bredr |
Johan Hedberg |
12 years ago |
1 file, +6, -0 |
| 7c6c6e17 |
lib: Add define for mgmt_set_bredr |
Johan Hedberg |
12 years ago |
1 file, +3, -0 |
| 0e33783f |
doc/mgmt-api: Add Set BR/EDR command definition |
Johan Hedberg |
12 years ago |
1 file, +30, -0 |
| eb505db7 |
tools/btmgmt: Fix minor whitespace issue |
Johan Hedberg |
12 years ago |
1 file, +2, -2 |
| cad62a72 |
tools/mgmt-tester: Update expected settings to support recent HS changes |
Johan Hedberg |
12 years ago |
1 file, +2, -2 |
| 997fa6b2 |
tools/mgmt-tester: Add test cases for enabling high speed |
Marcel Holtmann |
12 years ago |
1 file, +59, -0 |
| a1dcb380 |
tools/mgmt-tester: Cleanup indentation of test cases |
Marcel Holtmann |
12 years ago |
1 file, +197, -177 |
| cf8a492d |
lib: Fix use of uninitialized variable in sdp_set_profile_descs
Error path on default case was not breaking loop. To keep error
handling similar all error path were converted to use goto.
This fix following:
target C: libbluetooth <= external/bluetooth/bluez/android/../lib/sdp.c
lib/sdp.c: In function 'sdp_set_profile_descs':
lib/sdp.c:487:10: warning: 'values[0]' may be used uninitialized in
this function [-Wmaybe-uninitialized]
lib/sdp.c:2562:19: note: 'values[0]' was declared here
lib/sdp.c:545:11: warning: 'dtds[0]' may be used uninitialized in this
function [-Wmaybe-uninitialized]
lib/sdp.c:2562:9: note: 'dtds[0]' was declared here |
Szymon Janc |
12 years ago |
1 file, +8, -7 |
| c6e0cd59 |
test/test-hfp: Fix passing missing backlog parameter to sco.listen() |
Johan Hedberg |
12 years ago |
1 file, +1, -1 |
| ed6baf14 |
obexd/client: Fix not setting Transfer.Size for GET operations
GET operations may return the length header in the first response which
should be set as transfer Size property. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +11, -0 |
| df65753b |
gobex: Revert g_obex_pending_req_abort to static pending_req_abort
This reverts the changes introduced in
9095deb82572112fc0870095bf2222964610eafe that made pending_req_abort
public which is not necessary considering g_obex_cancel_req can do the
same and is safe to call even if the request is not pending. |
Luiz Augusto von Dentz |
12 years ago |
2 files, +2, -4 |