| cceb59d7 |
attrib: Fix PDU length check for Read by Type Request
PDU length must be either 7 or 21 octets. |
Anderson Lizardo |
12 years ago |
1 file, +1, -1 |
| 88cdd574 |
attrib: Reject incomplete PDU in dec_find_by_type_resp()
Otherwise, an incomplete PDU may be silently accepted (with any
remaining data discarded). |
Anderson Lizardo |
12 years ago |
1 file, +9, -0 |
| a9249eec |
attrib: Remove unnecessary local variables from dec_find_by_type_req()
Use number instead of "min_len", which is easier to review (with help of
the documented parameter sizes).
valuelen is redundant as *vlen can be used directly. |
Anderson Lizardo |
12 years ago |
1 file, +4, -10 |
| a8b353da |
attrib: Remove unnecessary NULL checks on dec_find_by_type_req()
Just assume that the caller will pass non-NULL pointers as arguments
(which is true for the only current caller of this function). |
Anderson Lizardo |
12 years ago |
1 file, +9, -15 |
| ef97296c |
attrib: Add extra PDU checks when decoding Read by Group Type Response
These checks are needed to avoid invalid memory access on bogus PDUs. |
Anderson Lizardo |
12 years ago |
1 file, +18, -0 |
| a5e6aafd |
attrib: Fix PDU length check for Read by Group Type Request
PDU length must be either 7 or 21 octets. |
Anderson Lizardo |
12 years ago |
1 file, +1, -1 |
| 22cf3b76 |
attrib: Remove unnecessary checks for PDU length on ATT encoding
Both userspace and kernel enforce a minimum ATT MTU of 23 octets, which
is also used as minimum size for buffers passed to ATT encoding
functions. Therefore, it is unnecessary to perform these checks on ATT
requests that are guaranteed to fit into 23 octets.
Also document ATT parameter lengths where a constant is being used for
calculating the PDU length. |
Anderson Lizardo |
12 years ago |
1 file, +46, -85 |
| 95b8a4ec |
attrib: Use att_put_u16() instead of htobs() + memcpy() |
Anderson Lizardo |
12 years ago |
1 file, +1, -3 |
| a2c1b506 |
attrib: Add missing g_error_free()
Also print error message. |
Anderson Lizardo |
12 years ago |
1 file, +6, -4 |
| 2704b4c8 |
attrib: Modify gatt_cb_t signature
Use standard C types instead of GLib ones (which are unnecessary here)
and move the "status" parameter to the first position, so it is
consistent with other callbacks. |
Anderson Lizardo |
12 years ago |
13 files, +36, -40 |
| d45c6df3 |
android/tester: Update bluetooth tests with DONE status |
Szymon Janc |
12 years ago |
1 file, +17, -16 |
| c31615b8 |
android/bluetooth: Log error for any non-success code
Returning non-SUCCESS code in command reply is considered error and
that includes DONE status. |
Szymon Janc |
12 years ago |
1 file, +4, -4 |
| 86905a89 |
android/bluetooth: Rename labels from failed to reply
This name match better and avoid confusion when setting status to
SUCCESS and then jumping to failed label. |
Szymon Janc |
12 years ago |
1 file, +14, -14 |
| b4dac305 |
android/bluetooth: Use HAL_STATUS_SUCCESS instead of _DONE in replies
JNI code in Android is mapping returned code to boolean value. Only
SUCCESS status is mapped to true and that value is returned to Java
code. This could result in faultyly triggering error path in Java
when returning DONE in command reply. |
Szymon Janc |
12 years ago |
1 file, +6, -6 |
| 96375e8a |
android/audio-msg: Simplify audio_rsp_open_stream
Reuse audio_preset in audio_rsp_open_stream since the data type is the
same. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +1, -2 |
| 88348600 |
android: Use LinkKeyPinLength instead of LinkKeyPINLength |
Marcel Holtmann |
12 years ago |
1 file, +2, -2 |
| 93d858bc |
android: Enable secure connections if supported |
Marcel Holtmann |
12 years ago |
1 file, +3, -0 |
| 16d8bce6 |
lib: Add management setting for secure connections |
Marcel Holtmann |
12 years ago |
1 file, +1, -0 |
| fc217fc5 |
tools: Add firmware conversion utility |
Marcel Holtmann |
12 years ago |
3 files, +206, -1 |
| e4925be8 |
shared: Fix crash if adapter is removed before mgmt event is received
If "Index Removed" mgmt event is received after a mgmt command was sent
by userspace, but before its Command Status/Complete event is received,
bluetoothd will eventually call mgmt_cancel_index(), which will destroy
the queue of pending commands. By the time request_complete() is called,
the request callback is no more valid, because the destroy callback was
already called.
Therefore, the fix is to simply ignore the event.
Valgrind output:
==3676== Invalid read of size 4
==3676== at 0x80BCD07: request_complete (mgmt.c:239)
==3676== by 0x80BCF72: can_read_data (mgmt.c:350)
==3676== by 0x80BBE22: read_callback (io-glib.c:164)
==3676== by 0x40C019D: g_io_unix_dispatch (giounix.c:166)
==3676== by 0x407FD45: g_main_context_dispatch (gmain.c:2539)
==3676== by 0x40800E4: g_main_context_iterate.isra.21 (gmain.c:3146)
==3676== by 0x408052A: g_main_loop_run (gmain.c:3340)
==3676== by 0x41BE4D2: (below main) (libc-start.c:226)
==3676== Address 0x10 is not stack'd, malloc'd or (recently) free'd |
Anderson Lizardo |
12 years ago |
1 file, +6, -4 |
| c70883b1 |
shared: Use a union for sockaddr for mgmt socket |
Marcel Holtmann |
12 years ago |
1 file, +8, -5 |
| a5932507 |
shared: Only mark notify as removed and not remove them right away |
Marcel Holtmann |
12 years ago |
1 file, +19, -16 |
| 763254e9 |
monitor: Remove two unneeded includes |
Marcel Holtmann |
12 years ago |
2 files, +1, -4 |
| 67f1aa11 |
monitor: Use generic utility macros for endian conversion |
Marcel Holtmann |
12 years ago |
5 files, +242, -209 |
| 0a8202cc |
shared: Add endian conversion macro for 64-bit little endian types |
Marcel Holtmann |
12 years ago |
1 file, +4, -0 |
| c2aef3ba |
shared: Fix the endian helper macros to work on big endian systems |
Marcel Holtmann |
12 years ago |
1 file, +10, -0 |
| 26724750 |
tools: Make use of generic endian conversion macros |
Marcel Holtmann |
12 years ago |
3 files, +0, -13 |
| e90a0743 |
emulator: Make use of generic endian conversion macros |
Marcel Holtmann |
12 years ago |
4 files, +4, -20 |
| 158a34a3 |
monitor: Make use of generic endian conversion macros |
Marcel Holtmann |
12 years ago |
1 file, +0, -5 |
| 9711f979 |
shared: Add general macro for handling endian conversion |
Marcel Holtmann |
12 years ago |
3 files, +7, -10 |
| 5e058245 |
android: Fix not using AM_CFLAGS in the HAL modules
Both bluetooth.audio.so and audio.a2dp.default.so should use AM_CFLAGS
ortherwise some quite obvious errors that otherwise would break the
build may be pushed upstream. |
Luiz Augusto von Dentz |
12 years ago |
1 file, +2, -2 |
| 518f1bdb |
android/audio: Add audio_ipc_cleanup function |
Lukasz Rymanowski |
12 years ago |
1 file, +9, -1 |
| 7560d1cd |
android/audio: Refactor create_audio_ipc
This patch adds creating listening audio ipc socket in AudioFlinger
context on audio_open() and moves accepting connection to ipc_th. |
Lukasz Rymanowski |
12 years ago |
1 file, +62, -58 |
| d0df2edd |
android: Fix error check from pthread_create
pthread_create() returns 0 on success or errno code which is non negative
number |
Lukasz Rymanowski |
12 years ago |
2 files, +5, -5 |
| 3ef04d30 |
android/audio: Prefix error log with "audio" |
Lukasz Rymanowski |
12 years ago |
1 file, +9, -7 |
| af1744db |
android/tester: Multi property check for test case
This patch allows to check multiple properties for test case. Properties
can be prioritized to allow check if they'll come in right order. Now
properties aren't treated as a "single" callback. In future in one
callback multiple properties can come. |
Grzegorz Kolodziejczyk |
12 years ago |
1 file, +392, -144 |
| 78d1f139 |
android/pan: Remove connected PAN devices on profile unregister call |
Ravi kumar Veeramally |
12 years ago |
1 file, +10, -0 |
| 7f445ac7 |
android/pan: Implement PAN enable HAL api at daemon side |
Ravi kumar Veeramally |
12 years ago |
1 file, +26, -4 |
| 423f6371 |
android/pan: Listen for incoming connections and accept in NAP role
Listen for incoming connections and accept it. Create bnep interface
add it to bridge and notify control and connection state information
through HAL. Remove the device on disconnect request. If android
settings UI does not have bluetooth tethering enabled it immediately
sends disconnect signal. |
Ravi kumar Veeramally |
12 years ago |
1 file, +182, -3 |
| a89e3dbd |
android/pan: Register Network Access Point
Register NAP server and adds bnep bridge. Removes bridge
on destroy call. Bridge mechanism is needed when device acting
as a server and listen for incoming connections. |
Ravi kumar Veeramally |
12 years ago |
1 file, +109, -5 |
| 64488fbf |
tools/mgmt-tester: Add basic SSP test case |
Johan Hedberg |
12 years ago |
1 file, +31, -0 |
| 8a596725 |
emulator: Add basic support for SSP completion |
Johan Hedberg |
12 years ago |
1 file, +78, -0 |
| cee10685 |
emulator/bthost: Add basic handling of user confirm request and SSP complete events |
Johan Hedberg |
12 years ago |
1 file, +34, -0 |
| 0143a51c |
emulator: Add dummy cmd complete handler for IO Capability Request Reply |
Johan Hedberg |
12 years ago |
1 file, +2, -0 |
| 9980744c |
emulator/bthost: Add basic IO Capability Request & Response handling |
Johan Hedberg |
12 years ago |
1 file, +58, -0 |
| 2781eb13 |
emulator: Add basic HCI_IO_Capability_Request_Reply handling |
Johan Hedberg |
12 years ago |
1 file, +56, -0 |
| bc3b7427 |
tools/bthost: Add dummy handler for HCI_Write_SSP_Mode completion |
Johan Hedberg |
12 years ago |
1 file, +2, -0 |
| 262ee6bd |
emulator/bthost: Track remote address in btconn |
Johan Hedberg |
12 years ago |
1 file, +6, -3 |
| 7a01a6d3 |
tools/mgmt-tester: Add support for enabling client side SSP |
Johan Hedberg |
12 years ago |
1 file, +17, -4 |
| 524808ae |
emulator: Add initial IO Capability Request sending when SSP is enabled |
Johan Hedberg |
12 years ago |
1 file, +27, -3 |